Our off shore contractors produce some of the worst code. But it’s impossible to get work done and also be vigilant enough to reject their bad pull requests. So basically you’ll end up looking a code one day that is godawful and think, “this is off shore”. And yep, git blame tells you you’re right.
It’s a contracting agency. Not individual contractors. Unfortunately we have lots of rubber stampers on our team who approve code while you’re not looking. And let me be clear, we have on shore who contribute awful code, too.
Our off shore contractors produce some of the worst code. But it’s impossible to get work done and also be vigilant enough to reject their bad pull requests. So basically you’ll end up looking a code one day that is godawful and think, “this is off shore”. And yep, git blame tells you you’re right.
How do code reviews work with contractors? Is it just “you don’t get paid until we approve it”?
It’s a contracting agency. Not individual contractors. Unfortunately we have lots of rubber stampers on our team who approve code while you’re not looking. And let me be clear, we have on shore who contribute awful code, too.
It’s all a mess.