• angel@sopuli.xyz
    link
    fedilink
    arrow-up
    3
    ·
    1 month ago

    Rustdesk looks good on the outside, but if you look inside, it has a really bad codebase and has done some sketchy stuff in the past.

    Last year, it installed custom root certificates as trusted on windows, which is a huge security risk: https://github.com/rustdesk/rustdesk/discussions/6444

    On linux systems, it forced its own autostart with no option to disable this behavior: https://github.com/rustdesk/rustdesk/issues/4863

    In the past, when it didn’t have Wayland support yet, it edited your GDM config and just disabled wayland: https://github.com/rustdesk/rustdesk/blob/1.1.9/src/platform/linux.rs#L411-L422

    Furthermore, the code quality is really bad. 90% of the linux platform-dependant code is just executing shell commands and parsing their output, while the same could be achieved in a safe way with proper rust builtins: https://github.com/rustdesk/rustdesk/blob/master/src/platform/linux.rs

    While I agree that Rustdesk works pretty flawlessly, the codebase and the behavior of the developers made me distrust the software and I don’t recommend using it.

    • Lettuce eat lettuce@lemmy.ml
      link
      fedilink
      arrow-up
      3
      ·
      1 month ago

      Really sad about this, because Rust Desk has been the absolute best remote access tool I’ve ever used in the IT world, and that includes many different professional tools like Ninja& Teamviewer.

      It’s so clean, easy to install and run, fast and low latency, handles multi-monitors great, runs on mobile, Linux, Windows, etc.

      Such a shame that it is mired in controversy.

    • haui@lemmy.giftedmc.com
      link
      fedilink
      arrow-up
      1
      ·
      1 month ago

      Okayyyy… thats not great. I just read one of the threads and thats scary.

      The person(s?) maintaining this seems to be VERY BAD at communicating. They did fix the auto start problem but did not at all discuss this from what I see. Thats not great.

    • Psyhackological@lemmy.ml
      link
      fedilink
      arrow-up
      1
      ·
      edit-2
      1 month ago

      Wth is that, that is the most anti-idiomatic code I have ever seen

      https://github.com/rustdesk/rustdesk/blob/master/src%2Fplatform%2Flinux.rs#L176

      pub fn get_cursor() -> ResultType<Option<u64>> {
          let mut res = None;
          DISPLAY.with(|conn| {
              if let Ok(d) = conn.try_borrow_mut() {
                  if !d.is_null() {
                      unsafe {
                          let img = XFixesGetCursorImage(*d);
                          if !img.is_null() {
                              res = Some((*img).cursor_serial as u64);
                              XFree(img as _);
                          }
                      }
                  }
              }
          });
          Ok(res)
      }
      

      I’m not an expert but this seems wrong.

    • Possibly linux@lemmy.zip
      link
      fedilink
      English
      arrow-up
      1
      ·
      edit-2
      1 month ago

      To add on:

      • There is no transparency about who is behind it. It just a Github account called “Rustdesk.” It could be a real company in Singapore or it could be some guy in China as people have speculated.

      • The Rustdesk software needs way more permissions than necessary. This became evident with the flatpak as they did sandbox escapes which prevented them from being on flathub

      • The Rustdesk distribution is entirely centralize release server run by Rustdesk. They could easily push out malware to lots of devices.

      • They have done some sketchy things in the past. One of the things they did was quietly switch Linux desktops back to X11.

      • The Rustdesk system is not terribly resistant to brute forcing. The weak password means they someone could try every combination.

      • Rustdesk docker deployment docker compose exposes all ports on the host. This is minor but it could lead to a sandbox excape.

      • Rustdesk servers keep getting hosted in countries that have freedom problems such as China and Russia.

      • bluetoque@lemmy.ca
        link
        fedilink
        English
        arrow-up
        1
        ·
        1 month ago

        Wow, I’m wondering how anyone would trust this software. It literally exposes your desktop. To me that requires top-tier trust level, i.e. nothing sketchy at all.

      • Fonzie!@ttrpg.network
        link
        fedilink
        arrow-up
        1
        ·
        edit-2
        1 month ago

        could be some guy in China

        I don’t see how that’s a problem, it’s not like it’s by a Chinese run company or like the Chinese government is spying on you; in the case you described it’d just be a rando with a hobby/vision.

        The fact that it keeps getting hosted in countries that have freedom problems, such as China and Russia, does concern me, though.

  • Possibly linux@lemmy.zip
    link
    fedilink
    English
    arrow-up
    2
    ·
    1 month ago

    DO NOT USE THIS

    This is a massive security risk and they have had so much controversy. They also routinely delete Github issues and discussions that question them. To top it off they are likely Chinese run.

    • PushButton@lemmy.world
      link
      fedilink
      arrow-up
      2
      ·
      1 month ago

      What?

      Rust doesn’t solve all security issues in codebase?

      People should take note of that; I surely did…

      • Possibly linux@lemmy.zip
        link
        fedilink
        English
        arrow-up
        0
        arrow-down
        1
        ·
        1 month ago

        China bans encryption and doesn’t allow you to use anything to thwart surveillance. I can’t say I want that in a remote access tool.

          • devfuuu@lemmy.world
            link
            fedilink
            arrow-up
            0
            ·
            edit-2
            1 month ago

            Wait until people find out america bans certain cryptographic things to help them out.

            • JustAnotherKay@lemmy.world
              link
              fedilink
              arrow-up
              1
              ·
              1 month ago

              As an american, the amount of people who refuse to accept that American Propaganda exists is staggering. I had an immediate reaction to seeing “China is good though” and I have no way of knowing if it’s justified because I’ve been my told my entire life that China is an evil shithole by American propaganda.

              To take it a step further and say “America doesn’t have your best interest at heart” is deeply unsettling to the vast majority of Americans who blindly hand away their freedoms in the name of Freedom. Wait until people find out that our country is just like all the ones we’re taught to hate

          • sunbeam60@lemmy.one
            link
            fedilink
            arrow-up
            0
            ·
            1 month ago

            Of course China uses encryption. So an obtuse, direct reading of that statement allows you, correctly, to say the commenter is wrong.

            But what the commenter probably meant was “China bans the use of encryption that prevents the Chinese state from reading what is being exchanged” and that is confidently right. I’ve operated teams in China where we had a secret category 1 incident when it was discovered a couple of our devs had set up a VPN between a Chinese and a western service that didn’t go through the official Chinese-state controlled VPN services.

            They absolutely do not want data they cannot read.

              • sunbeam60@lemmy.one
                link
                fedilink
                arrow-up
                1
                ·
                edit-2
                1 month ago

                lol. I AM the source. DM me with your LinkedIn handle, I’ll connect with you to validate my identity and you can tell anybody else watching that the story is legit. I don’t want to spill too many details in public as I don’t want to involve my old company in it.

                And in terms of “state controlled VPN” services, it’s not that the Chinese state runs honeypot VPNs for companies (though they most definitely do for their own citizens), but that to have a license to operate a cloud service in China, you have to enforce CSL and that means they get private companies, western too, to do their bidding. If you encrypt data, you’ll get a stern call (as we did).

  • pop@lemmy.ml
    link
    fedilink
    arrow-up
    1
    ·
    1 month ago

    Itsfoss is blogspam and often have many mistakes and wrong info. People should really stop posting links from them.

  • gibdos@lemmy.world
    link
    fedilink
    arrow-up
    1
    ·
    1 month ago

    Yeah it’s pretty awesome. My only gripe with it is the fact that it is super annoying when you want to send a client with your self-hosted urls to a customer.

    You can either awkardly add it to the filename or you need to fork the client and build it yourself. Kind of sucks that the easier custom client function is stuck behind their subscription.

  • souperk@reddthat.com
    link
    fedilink
    arrow-up
    1
    ·
    1 month ago

    I have setup a rustdesk server with docker, it was surprisingly easy to get started. It was for a friend who is managing the IT services of a small factory, the completely switched from TeamViewer and they are satisfied. More importantly their users, who are worse than your average windows user, found the transition relatively painless.