A fork/continuation of the original since the author has been away for a while. Supports kernels up to 6.15 with lots of other changes.

  • InvertedParallax@lemm.ee
    link
    fedilink
    English
    arrow-up
    1
    arrow-down
    5
    ·
    edit-2
    1 day ago

    What in the fuck are you even talking about?

    PS5 is bluetooth, standard bluetooth, and wired uses both standard HID and standard usb audio, my point is: Why isn’t MSFT?

    Also, since you clearly don’t know the first fucking thing you’re talking about:

    After 2016, when Bluetooth connectivity was introduced with the second controller revision (model 1708) alongside the Xbox One S, Microsoft rebranded its proprietary connection protocol as “Xbox Wireless”.[10] Xbox Wireless uses the same frequency range as Bluetooth (2.40-2.48 GHz), but has a higher transmit power, improving range and input latency. Starting in 2017, Microsoft began working with third-party manufacturers to produce additional accessories using Xbox Wireless, with the first class being headsets.[11]

    With a firmware update that began rolling out in September 2021, controllers with Bluetooth are able to pair with devices using both wireless protocols, allowing those controllers to switch connections by double-tapping the pairing button.[12]

    Drivers were released in June 2014 to allow Xbox One controllers to be used over a USB connection on PCs running Windows 7 or later.[69] The Xbox One Wireless Adapter for Windows is a USB dongle that allows up to eight controllers to be used at once wirelessly.[70]

    Look at how stupid broken this is! You need drivers to use it over standard USB!

    Everything about this design is broken, it should be kicked out of the kernel and MSFT should release firmware that actually implements HID like normal, non-stupid people.

    8bitdo has exactly this, same dongle system and pairing and again, it works perfectly without any drivers at all, because they’re not morons.

    • kkj@lemmy.dbzer0.com
      link
      fedilink
      English
      arrow-up
      3
      ·
      14 hours ago

      The 8bitdo version is easier to implement because it’s one dongle per controller. The Xbox dongle supports eight controllers per dongle. This complicates things; I assume they didn’t want to emulate an eight-port USB hub on the dongle.

      You can use BT, but there’s a reason 8bitdo has a dongle as well: BT has worse latency, I assume due to protocol overhead.

      And at least Xbox controllers are cross-compatible. You can’t use a DS4 on a PS5, even if you’re playing a PS4 game.

      • InvertedParallax@lemm.ee
        link
        fedilink
        English
        arrow-up
        1
        ·
        edit-2
        11 hours ago

        assume they didn’t want to emulate an eight-port USB hub on the dongle.

        https://github.com/abcminiuser/lufa

        Literally a kid did this in high school, this is without hardware support, just GPIO, but he also implemented the full stack on avrusbs and cortex-ms, and one thing he emulated was multiple devices on a hub.

        • kkj@lemmy.dbzer0.com
          link
          fedilink
          English
          arrow-up
          2
          ·
          edit-2
          10 hours ago

          Well, yeah, obviously it can be done. What’s the latency, though? A hub’s muxing alternates between packets from different devices, but even USB 1.1 has 64B packets, leaving 64b per controller if you report them all in one packet. That’s 15 digital buttons, 6b per axis, and 13b left over for routing.

          However, I can’t think of a way to get the computer to decode one 64B packet into eight separate HID polls without a custom driver. If you use a hub, you’re limited to 8kHz total by the spec, but many EHCI controllers limit that to 1kHz. 125Hz per player is not great.

          I can’t confirm that this is the reason or that there isn’t a different way around the restriction, but it seems likely from what I know of USB hubs.

          TL;DR: with a custom driver, you can report all controllers on all USB polls rather than each taking up a whole interval, giving you 8x the polling rate compared to an emulated hub with 8 standard HIDs.

          • InvertedParallax@lemm.ee
            link
            fedilink
            English
            arrow-up
            1
            ·
            edit-2
            9 hours ago

            Firstly, it’s not a real hub, it’s an emulated hub, and you can do that emulating everything as USB 2.0.

            Secondly you can have multiple hid interface endpoints on a single device.

            Thirdly, you wouldn’t be polling, these would be hid interrupt urbs, and you can storm them 1 per micropacket if you want, they just show up in the ehci buffers.

            Finally, no human is overflowing the hid interface like this, not even 8 of them.

            • kkj@lemmy.dbzer0.com
              link
              fedilink
              English
              arrow-up
              1
              ·
              8 hours ago
              1. You’d presumably do it as 2.0, but I used 1.1 for the numbers just to demonstrate that you can definitely fit 8 controllers into a packet even if you go for unreasonable levels of backwards compatibility.
              2. Without a hub, I’m not aware of a way to exceed 8 axes per HID device (7 in Windows for some reason). Each Xbox controller has six, so even two controllers can’t be one device.
              3. As far as I can find, most USB 2 implementations can take up to 1000 packets per second per root hub, regardless of packet size. I was already assuming one controller poll per packet for the hub version, and that’s 125Hz per controller with all eight.
              4. You aren’t actually pressing buttons at 125Hz, no. However, if your input is barely too late for one 125Hz poll, you can get enough delay to be noticeable in fast-paced games. Most controllers and mice use 1kHz for this reason, with some even supporting up to 8kHz if your USB implementation supports it (which apparently is pretty common with xHCI, but Microsoft didn’t want to rely on that for obvious reasons).
              • InvertedParallax@lemm.ee
                link
                fedilink
                English
                arrow-up
                1
                ·
                5 hours ago

                if your input is barely too late for one 125Hz poll,

                So those polls are generally isochronous to the USB bus transaction state, not based on polling frequency of the CPU, what happens is:

                1. USB interrupt URB comes in to HCI controller,.URB descriptor written to descriptor chain.

                2. Controller adds to descriptor chain, once chain length > WAT (| Timeout), interrupt and start processing incoming URBs.

                3. In interrupt controller, follow chain, push URBs onto usb stack queue, trigger handler tasklet

                4. Stack processes URB, routes to proper class driver

                5. Class driver checks if URB has file handle open (or has open ref from drivers like HID/input).

                6. If so, poll or other input read() returns value.

                Now it’s possible there are multi-input poll reads in games, and I’m doing linux of course.

                For MSFT it’s URB -> IRP -> WDM filter driver stack -> kernel32/directinput or win32 input stack (WNDPROCs after routing).

                In any of these cases, I’m struggling to see how interrupts would come in faster with the same code on PC.

                See, the same code probably runs on both MSFT and normal hardware, so it’s going to have the same structure, unless you actually believe a dev team is optimizing input latency that much, that’s often the lowest priority, they’ll optimize video lag more because it’s more noticeable. The engines themselves use DirectInput, and that’s routed through to libinput in WINE, and the same for all devices.

                Btw, DirectInput has a device-based interface, so it couldn’t poll like this anyway, basically each controller has its own input queue that is round-robin and pluck stuff out of their input stream when available.

                In any case, you’re not getting the latency improvement, both because it’s so different in software and because nothing can appreciate this.

                I’m not trying to be extra autistic for no reason, I’ve just had to make these decisions before, and these are how we have to think.

    • kadup@lemmy.world
      link
      fedilink
      English
      arrow-up
      5
      ·
      1 day ago

      We are talking about a driver for the Xbox One wireless adapter.

      Microsoft never submitted a kernel driver for this, it’s a third party module. It’s not Bluetooth - it’s WiFi, using a proprietary blob for authentication.

      Not a single one of your claims in this entire thread have been correct.

      • InvertedParallax@lemm.ee
        link
        fedilink
        English
        arrow-up
        1
        arrow-down
        1
        ·
        5 hours ago

        It’s not Bluetooth - it’s WiFi, using a proprietary blob for authentication.

        You’ve literally missed my whole point.

        Playstation link is this exact same thing, and btw, both controllers are dual-mode bluetooth and “high-speed wireless interface”, which is basically wifi or wifi-direct or some proprietary variant.

        My point is, why isn’t it like Playstation link which just presents as HID devices and usb-audio devices, without a driver at all? Same low-latency, they even do LDAC.